From 0c9dcd944e532f2e97773305397d726d78af97e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kha=C3=AFs=20COLIN?= <khais.colin@gmail.com>
Date: Fri, 25 Apr 2025 13:17:29 +0200
Subject: [PATCH] fix(parsing): report unclosed ( error

---
 src/parser/cmd_parsing.c |  6 +++---
 test.sh                  | 18 ++++++++++++++++++
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/src/parser/cmd_parsing.c b/src/parser/cmd_parsing.c
index 6d324f9..8331320 100644
--- a/src/parser/cmd_parsing.c
+++ b/src/parser/cmd_parsing.c
@@ -3,10 +3,10 @@
 /*                                                        :::      ::::::::   */
 /*   cmd_parsing.c                                      :+:      :+:    :+:   */
 /*                                                    +:+ +:+         +:+     */
-/*   By: jguelen <jguelen@student.42.fr>            +#+  +:+       +#+        */
+/*   By: khais <marvin@42.fr>                       +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2025/03/31 10:28:28 by jguelen           #+#    #+#             */
-/*   Updated: 2025/04/24 16:39:14 by jguelen          ###   ########.fr       */
+/*   Updated: 2025/04/25 13:17:56 by khais            ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -65,7 +65,7 @@ t_cmd	*minishell_parse(t_minishell *app, char *command_line)
 	if (!tokens)
 		return (expecting_quote_error(app));
 	root_cmd = minishell_cmds_parse(app, &tokens);
-	if (root_cmd == NULL && ft_errno_get() != FT_ESUCCESS)
+	if ((root_cmd == NULL && ft_errno_get() != FT_ESUCCESS) || tokens != NULL)
 	{
 		if (tokens == NULL)
 			parse_error_newline(app);
diff --git a/test.sh b/test.sh
index c2c3f32..c0a446b 100755
--- a/test.sh
+++ b/test.sh
@@ -1021,4 +1021,22 @@ minishell: cat: Permission denied
 126
 EOF
 
+when_run <<EOF "unclosed ("
+(echo unclosed paren
+EOF
+expecting <<"EOF"
+minishell: syntax error near unexpected token `newline'
+EOF
+
+when_run <<"EOF" "unclosed ( in export"
+export VAR=bon(jour
+echo $?
+echo var=$VAR
+EOF
+expecting <<"EOF"
+minishell: syntax error near unexpected token `('
+2
+var=
+EOF
+
 finalize