logistic-bot/minishell
1
0
Fork 0
mirror of https://codeberg.org/la-chouette/minishell.git synced 2025-12-06 07:28:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: ';' is not a metacharacter

Browse source 
Co-authored-by: jguelen <jguelen@student.42lehavre.fr>
This commit is contained in:
Khaïs COLIN 2025-02-11 18:24:30 +01:00
parent e877b8dbd5
commit 6e1552a35d
Signed by: logistic-bot
SSH key fingerprint: SHA256:RlpiqKeXpcPFZZ4y9Ou4xi2M8OhRJovIwDlbCaMsuAo
2 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/parser/matchers/metacharacter.c
View file

@ -6,7 +6,7 @@
/* By: kcolin <marvin@42.fr> +#+ +:+ +#+ */ /* By: kcolin <marvin@42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */ /* +#+#+#+#+#+ +#+ */
/* Created: 2025/02/06 15:23:31 by kcolin #+# #+# */ /* Created: 2025/02/06 15:23:31 by kcolin #+# #+# */
/* Updated: 2025/02/06 15:47:42 by kcolin ### ########.fr */ /* Updated: 2025/02/11 19:04:03 by khais ### ########.fr */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -16,14 +16,13 @@
/* /*
** return true if the character is a metacharacter ** return true if the character is a metacharacter
** **
** Bash reference manual: ** Bash reference manual: A character that, when unquoted, separates words. A
** A character that, when unquoted, separates words. A metacharacter is a space, ** metacharacter is a space, tab, newline, or one of the following characters:
** tab, newline, or one of the following characters: ‘|’, ‘&’, ‘;’, ‘(’, ‘)’, ** ‘|’, ‘&’, ‘(’, ‘)’, ‘<’, or ‘>’.
** ‘<’, or ‘>’.
*/ */
bool is_metacharacter(char c) bool is_metacharacter(char c)
{ {
if (c == ' ' || c == '\t' || c == '\n' || c == '|' || c == '&' || c == ';' if (c == ' ' || c == '\t' || c == '\n' || c == '|' || c == '&'
|| c == '(' || c == ')' || c == '<' || c == '>') || c == '(' || c == ')' || c == '<' || c == '>')
return (true); return (true);
return (false); return (false);

14
tests/metacharacters.c
View file

@ -6,7 +6,7 @@
/* By: kcolin <marvin@42.fr> +#+ +:+ +#+ */ /* By: kcolin <marvin@42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */ /* +#+#+#+#+#+ +#+ */
/* Created: 2025/02/06 15:21:00 by kcolin #+# #+# */ /* Created: 2025/02/06 15:21:00 by kcolin #+# #+# */
/* Updated: 2025/02/06 15:57:40 by kcolin ### ########.fr */ /* Updated: 2025/02/11 18:32:01 by khais ### ########.fr */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -40,12 +40,20 @@ void test_metacharacters(void)
assert(!is_metacharacter(c)); assert(!is_metacharacter(c));
c++; c++;
} }
char *metachars = " \t\n|&;()<>"; char *not_metachars = ";[]{}*+=_-";
int i = 0; int i = 0;
while (not_metachars[i] != '\0')
{
dprintf(STDERR_FILENO, "%c", not_metachars[i]);
assert(!is_metacharacter(not_metachars[i]));
i++;
}
char *metachars = " \t\n|&()<>";
i = 0;
printf("\nmetachar:"); printf("\nmetachar:");
while (metachars[i] != '\0') while (metachars[i] != '\0')
{ {
printf("%c", metachars[i]); dprintf(STDERR_FILENO, "%c (%d) ", metachars[i], metachars[i]);
assert(is_metacharacter(metachars[i])); assert(is_metacharacter(metachars[i]));
i++; i++;
} }