446 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Khaïs COLIN	701174fc1b	feat(debug): function to easily treeprint a worddesc	2025-04-18 09:20:49 +02:00
Khaïs COLIN	9271b7fa92	fix(parsing/pipeline): leak when optional pipeline returns NULL	2025-04-18 09:19:25 +02:00
Khaïs COLIN	6cc6e6cfb5	feat(debug): add function to easily treeprint a cmd	2025-04-17 12:28:57 +02:00
Khaïs COLIN	f1a0af09f8	feat(here_doc): handle signals (^C, ^\) correctly ... This is a bit of a big commit, because I had to move some stuff to other files, sorry about that. I can split it up if it's too big to review.	2025-04-17 12:06:48 +02:00
Khaïs COLIN	5e6d7b3b4e	fix(parsing/here_doc): segfault & invalid fd & premature exit	2025-04-17 11:25:59 +02:00
Khaïs COLIN	3be2969946	fix(parsing/simple_cmd): leak when invalid redirection after word in simple_cmd	2025-04-16 18:21:33 +02:00
Khaïs COLIN	49a897b44e	subst/variable: remove special handling of positional variables ... Including only half support does not make sense, it could cause more problems than it solves.	2025-04-16 18:05:11 +02:00
Khaïs COLIN	d53e40d3f4	fix(subst/variable): invalid identifiers were having their $ swallowed ... It is safe to delete this part: ```c if (!rep) return (NULL); ``` because rep is always returned, and no other code depends on that value	2025-04-16 17:50:23 +02:00
Khaïs COLIN	733ae1093a	fix(exec): correctly exit subprocesses, do not keep multiple shells in parallel	2025-04-16 17:30:25 +02:00
Khaïs COLIN	2ea4afda4a	clean: move around some imports	2025-04-16 16:41:54 +02:00
Khaïs COLIN	96e46e9130	fix(parsing/cmdgroup): report error the same way as everywhere else, prevent double report ... before: ``` $ () minishell: syntax error near unexpected token `)' minishell: syntax error near unexpected token `)' ``` after: ``` $ () minishell: syntax error near unexpected token `)' ``` This probably fixes a few bugs as well, but I didn't look too hard. It just seemed nicer to have a consistent way to report errors.	2025-04-16 15:52:22 +02:00
Khaïs COLIN	ced979dd31	fix(parsing/simple_cmd): report error the same way as everywhere else, prevent leak	2025-04-16 15:38:51 +02:00
Khaïs COLIN	d652f32cff	feat(debug): a way to easily debug a wordlist	2025-04-16 15:30:18 +02:00
Khaïs COLIN	18225f3356	fix(executing): return code on unknown cmd was unchanged, is now set to 127	2025-04-16 15:00:20 +02:00
Khaïs COLIN	9a32220945	redir_parsing: fix memory leak when parsing a redirection with an operator as specifier ... if the specifier was not WORD_TOKEN, the operator was not being freed	2025-04-16 14:13:01 +02:00
Khaïs COLIN	84a246f6f6	parsing: fix redir accepting operators as specifiers ... before: $ >>>>> minishell: syntax error near unexpected token `newline' after: $ >>>>> minishell: syntax error near unexpected token `>>' >> is now correctly detected as an operator, and not a word	2025-04-16 13:59:14 +02:00
Khaïs COLIN	9593851149	parsing: show errors for unexpected newline ... $ < minishell: syntax error near unexpected token `newline' $ > minishell: syntax error near unexpected token `newline' $ << minishell: syntax error near unexpected token `newline' $ >> minishell: syntax error near unexpected token `newline'	2025-04-16 13:16:34 +02:00
Khaïs COLIN	e1a1a43041	parsing: refactor cmds_parse into own file	2025-04-16 13:13:55 +02:00
Khaïs COLIN	73d691c0b4	parsing: refactor group_or_simple_parse into group_cmd_parse.c	2025-04-16 13:08:50 +02:00
Khaïs COLIN	a5103fa733	clean: remove unused paren files	2025-04-16 13:05:34 +02:00
Khaïs COLIN	dd30b44b93	parsing: refactor minishell_opt_cmds_parse into own file	2025-04-16 13:03:49 +02:00
Khaïs COLIN	ee5811ad63	ignore zms_tester	2025-04-16 12:48:23 +02:00
Khaïs COLIN	942217a45a	tests: update tests to reflect new parser	2025-04-15 15:47:18 +02:00
Khaïs COLIN	81ba53237c	parsing: do not reset last_return_value at start of parsing ... we need to preserve it, to be able to show the return value from the last command	2025-04-15 15:45:29 +02:00
Khaïs COLIN	1a949bdcab	minishell: reinstante interactive mode	2025-04-15 15:27:20 +02:00
Khaïs COLIN	0579d1f2fc	env: correctly handle write errors such as /dev/full ... The exit status of 125 for env in case of failure is documented in env(1).	2025-04-15 15:19:27 +02:00
Khaïs COLIN	ffaf2582a3	pwd: correctly handle write errors	2025-04-15 15:19:27 +02:00
Khaïs COLIN	cfc95994de	echo: correctly handle write errors such as /dev/full	2025-04-15 15:19:27 +02:00
Khaïs COLIN	871180f6d8	connec_pipe_cmd_execute: setup pipes between commands	2025-04-15 15:19:27 +02:00
Khaïs COLIN	81febcfcdd	debug: show command about to be executed in debug mode	2025-04-15 15:19:27 +02:00
Khaïs COLIN	204ed35ff4	fix(connec_cmd_execute): do not execute more than one command per process	2025-04-15 15:17:52 +02:00
Khaïs COLIN	596b21fc2f	debug, destroy all new types (also some code for testing it)	2025-04-15 15:17:51 +02:00
Khaïs COLIN	82da182773	fix: potential buffer overflow caused by missing terminating null byte in t_buffer ... This only occurs in specific circumstances where the number of bytes to be added to a t_buffer via the ft_buffer_push_buf function is exactly equal to the number of free bytes in the current underlying buffer. This does not occur if the number of bytes to add to the buffer is smaller than that, since we allocate new space using ft_calloc. In these circumstances, since no terminating null byte is added, other code may read past the end of the buffer, causing a buffer overflow.	2025-04-15 15:17:51 +02:00
Khaïs COLIN	3ec90f7770	token_type: assign token_type to worddesc during wordsplit ... Also added some tests for that part.	2025-04-15 15:17:51 +02:00
Khaïs COLIN	4d6a64bf6a	debug: worddesc show more information ... This seems appropriate since worddescs are getting more and more complex: markers, flags, tokentypes, ...	2025-04-15 15:17:51 +02:00
Khaïs COLIN	6576c47b56	exec: command to toggle execution ... Execution starts out being enabled. But it can be toggled on and off by using the .exec command.	2025-04-15 15:17:51 +02:00
Khaïs COLIN	ac411d36cc	debug: special command can turn debug mode on and off ... Using the .debug command, debug mode can be toggled. It starts turned off. When it is on, each command, before being executed, is debug-printed using the tree-printing facilities.	2025-04-15 15:16:51 +02:00
Khaïs COLIN	18014cda98	token_type: add field with no logic for populating it	2025-04-15 15:15:30 +02:00
Khaïs COLIN	5716c4b3dc	parsing: pass correct arguments to prevent use-after-free	2025-04-15 15:15:30 +02:00
Khaïs COLIN	ba9751e089	do postprocessing for each simple_cmd before execution	2025-04-15 15:13:17 +02:00
Khaïs COLIN	386d2bcb3a	exec: correct error and return value when cmd is a directory ... minishell: /: Is a directory $? = 126	2025-04-15 15:11:50 +02:00
Khaïs COLIN	d08c9a6727	tests: check simple noops	2025-04-15 15:11:50 +02:00
Khaïs COLIN	bb1390aac5	simple_cmd_execute: handle redirections ... I am very uncertain on if this is actually correct, but I am unable to test it very much atm	2025-04-15 15:11:50 +02:00
Khaïs COLIN	6f75f2d181	connec_cmd_execute: naive recursive pipe implementation (does not handle redirection)	2025-04-15 15:11:26 +02:00
Khaïs COLIN	df73b3d0c7	connec_cmd_execute: handle && and ||	2025-04-15 15:11:26 +02:00
Khaïs COLIN	8feacccb15	group_cmd_execute: fork and passthrough to cmd_execute	2025-04-15 15:11:26 +02:00
Khaïs COLIN	425722801b	refactor(do_waitpid): put into own file for easier acces from other modules	2025-04-15 15:11:26 +02:00
Khaïs COLIN	f9f8a804a3	cmd_execute: execute simple commands	2025-04-15 15:11:11 +02:00
Khaïs COLIN	7af032539a	cmd_execute: initial scafholding	2025-04-15 15:11:11 +02:00
Khaïs COLIN	881c7f264c	signal: if a command is terminated by SIGQUIT, display that it core dumped	2025-04-15 15:11:11 +02:00