111 commits

Author	SHA1	Message	Date
Khaïs COLIN	3f08189aae	fix(parsing/redirect): sometimes do not take a redirection into account ... debug notes: ++++++++++++++++++++++++++++++++++++++++++++++++++++ failed: ambiguous redirect ++++++++++++++++++++++++++++++++++++++++++++++++++++ ++++ test input: export target="outfile1 outfile2" echo hello > $target echo $? echo hi >> $target echo $? cat < $target echo $? ls echo $? ++++ Got output: hello 0 hi 0 echo $? ls echo $? ++++ But expected: minishell: $target: ambiguous redirect 1 minishell: $target: ambiguous redirect 1 minishell: $target: ambiguous redirect 1 0 Reproduced this with rr record --cahos, see /home/khais/.local/share/rr/minishell-48 $ export target="outfile1 outfile2" $ echo hi > $target hi Break in simple_cmd_execute, second command has no redirections when it should have some, presumably this comes from some uninitialized memory somewhere.	2025-04-24 13:26:40 +02:00
Khaïs COLIN	920ad586e1	refactor(redirect): ambiguous redirect message to own file	2025-04-24 12:45:00 +02:00
Khaïs COLIN	2dd20b21bc	feat(redir): fieldsplit redir target, and handle ambiguous redirects	2025-04-24 12:44:33 +02:00
Khaïs COLIN	701174fc1b	feat(debug): function to easily treeprint a worddesc	2025-04-18 09:20:49 +02:00
Khaïs COLIN	f1a0af09f8	feat(here_doc): handle signals (^C, ^\) correctly ... This is a bit of a big commit, because I had to move some stuff to other files, sorry about that. I can split it up if it's too big to review.	2025-04-17 12:06:48 +02:00
Khaïs COLIN	5e6d7b3b4e	fix(parsing/here_doc): segfault & invalid fd & premature exit	2025-04-17 11:25:59 +02:00
Khaïs COLIN	e1a1a43041	parsing: refactor cmds_parse into own file	2025-04-16 13:13:55 +02:00
Khaïs COLIN	a5103fa733	clean: remove unused paren files	2025-04-16 13:05:34 +02:00
Khaïs COLIN	dd30b44b93	parsing: refactor minishell_opt_cmds_parse into own file	2025-04-16 13:03:49 +02:00
Khaïs COLIN	1a949bdcab	minishell: reinstante interactive mode	2025-04-15 15:27:20 +02:00
Khaïs COLIN	871180f6d8	connec_pipe_cmd_execute: setup pipes between commands	2025-04-15 15:19:27 +02:00
Khaïs COLIN	81febcfcdd	debug: show command about to be executed in debug mode	2025-04-15 15:19:27 +02:00
Khaïs COLIN	3ec90f7770	token_type: assign token_type to worddesc during wordsplit ... Also added some tests for that part.	2025-04-15 15:17:51 +02:00
Khaïs COLIN	df73b3d0c7	connec_cmd_execute: handle && and ||	2025-04-15 15:11:26 +02:00
Khaïs COLIN	8feacccb15	group_cmd_execute: fork and passthrough to cmd_execute	2025-04-15 15:11:26 +02:00
Khaïs COLIN	425722801b	refactor(do_waitpid): put into own file for easier acces from other modules	2025-04-15 15:11:26 +02:00
Khaïs COLIN	7af032539a	cmd_execute: initial scafholding	2025-04-15 15:11:11 +02:00
Khaïs COLIN	f0145d26f4	signal: do not exit shell on SIGINT, ignore SIGQUIT	2025-04-15 15:08:06 +02:00
Khaïs COLIN	be183b99ee	minishell: do wildcard expansion	2025-04-15 15:06:46 +02:00
Khaïs COLIN	32e3976774	field splitting: implement field splitting	2025-04-15 15:05:52 +02:00
Khaïs COLIN	d40560bb37	unset: implement unset	2025-04-15 15:03:13 +02:00
Khaïs COLIN	1ef8b7a0ae	env: implement builtin env	2025-04-15 15:03:13 +02:00
Khaïs COLIN	0de583cf45	echo: implement builtin echo	2025-04-15 15:03:13 +02:00
Khaïs COLIN	f1c132337b	exit: work for simple arguments ... This does not address non-integer arguments, or extremly high/low arguments.	2025-04-15 15:03:13 +02:00
Khaïs COLIN	5b7367925f	simple_cmd refactor: put subprocess functions in own file ... This clears some space for new functions later	2025-04-15 14:41:44 +02:00
Khaïs COLIN	9e79a0829a	fix: do not read ahead in STDIN ... The Open Group Base Specifications Issue 8 IEEE Std 1003.1-2024 sh — shell, the standard command language interpreter says: > When the shell is using standard input and it invokes a command that also uses > standard input, the shell shall ensure that the standard input file pointer > points directly after the command it has read when the command begins > execution. It shall not read ahead in such a manner that any characters > intended to be read by the invoked command are consumed by the shell (whether > interpreted by the shell or not) or that characters that are not read by the > invoked command are not seen by the shell. We used the default BUFFER_SIZE for get_next_line of 1024, which caused us to read ahead farther than was allowed by the Open Group Base Specification. Setting BUFFER_SIZE=1 ensures that we don't read too far ahead, since get_next_line will always immediatly stop once a newline is found. This is for me the simplest way to solve this issue.	2025-04-15 14:41:44 +02:00
Khaïs COLIN	4de1d0024a	parsing: refactor out the last two functions needed to pass the norm	2025-04-15 14:41:43 +02:00
Khaïs COLIN	5e84e9a111	parsing: remove (at least some) dead code	2025-04-15 14:41:43 +02:00
Khaïs COLIN	218be08049	parsing: refactor group_cmd_parse into own file	2025-04-15 14:41:43 +02:00
Khaïs COLIN	b7871be426	parsing: refactor minishell_optional_pipeline_parse into own file	2025-04-15 14:41:43 +02:00
Khaïs COLIN	811ce3ef8e	parsing: refactor minishell_simple_cmd_parse into own file	2025-04-15 14:41:43 +02:00
Khaïs COLIN	e033909819	makefile: generate depfiles for the correct object files ... The depfiles were completely ineffective. Now this is fixed. The -MT argument sets the path for the dependenency root. By default it is set only to a filename, and thus does not include the full path of the file.	2025-04-15 14:41:43 +02:00
Khaïs COLIN	9a58198303	parsing: refactor minishell_redirect_parse to own file	2025-04-15 14:41:43 +02:00
Khaïs COLIN	d4197fec38	parsing: create specialised function to create a t_cmd	2025-04-15 14:41:43 +02:00
Khaïs COLIN	283458b24f	parsing: put redirect specific functions into own file	2025-04-15 14:41:43 +02:00
Khaïs COLIN	d40b6c3586	debug, destroy all new types (also some code for testing it)	2025-04-15 14:41:43 +02:00
Khaïs COLIN	1866da6ea6	fix: make it compile	2025-04-11 16:57:31 +02:00
Jérôme Guélen	10a3c9c411	parse-cmd: Various fixes and a rotation of the parsing tree	2025-04-08 12:14:38 +02:00
Khaïs COLIN	0a80b9fbe3	simple_cmd executing refactor: put builtin related utilities into own file	2025-04-01 16:38:41 +02:00
Khaïs COLIN	299e016a27	export: handle simple cases	2025-04-01 14:39:02 +02:00
Khaïs COLIN	bac3512898	minishell: do variable substitution in postprocessing	2025-04-01 13:50:14 +02:00
Khaïs COLIN	e93e6efb93	builtins: cd: implement cd to absolute paths	2025-03-31 16:34:48 +02:00
Khaïs COLIN	5ce4a2b85f	builtin: implement pwd	2025-03-31 14:54:40 +02:00
Khaïs COLIN	1c4733b1cc	here_doc: print error if failed to create temp file	2025-03-28 19:10:43 +01:00
Khaïs COLIN	a4c482e8f9	here_doc: perform variable expansion	2025-03-28 16:45:28 +01:00
Jérôme Guélen	5ff990ef50	Parsing-refactor: Determining structures.	2025-03-28 15:03:15 +01:00
Khaïs COLIN	befe219436	simple_cmd executing: works with arguments and env ... Does not handle redirections at all, no special facilities are in place to allow nofork or builtin execution.	2025-03-28 14:50:37 +01:00
Khaïs COLIN	f07a80c762	postprocessing: do quote removal	2025-03-28 14:50:37 +01:00
Khaïs COLIN	0fbfee7d78	cmdgroup parsing: parse cmdlist surrounded by parentheses	2025-03-28 14:50:37 +01:00
Khaïs COLIN	185a069044	cmdgroup parsing refactor: use builder pattern ... This will make it easier to add the next logic stuff to it	2025-03-28 14:50:37 +01:00