logistic-bot/minishell
1
0
Fork 0
mirror of https://codeberg.org/la-chouette/minishell.git synced 2025-12-06 07:28:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
439 commits 2 branches 0 tags 2 MiB
Commit graph

69 commits

Author SHA1 Message Date
Khaïs COLIN
f0f19c3c0a fix(exec/and or): was exiting too soon 2025-04-25 18:03:12 +02:00
Khaïs COLIN
9fcb34e1d5 feat(builtins/cd): on error, print path 2025-04-25 16:08:10 +02:00
Khaïs COLIN
29bbb5e572 fix(command_not_found): unset or empty PATH leads to No such file or directory error 2025-04-25 15:52:02 +02:00
Khaïs COLIN
527a624765 fix(exec): return code 126 when command is found but permission denied 2025-04-25 12:40:34 +02:00
Khaïs COLIN
5fb054d403 fix(redirection): restore std fds on redirection error 
debug notes:
$ cat << eof > /root/outfile
hello
eof
minishell: open: Permission denied
minishell: hello: command not found
==42382==
==42382== FILE DESCRIPTORS: 9 open (3 std) at exit.
==42382== Open file descriptor 8: /dev/pts/3
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9CC: handle_redirections (src/executing/simple_cmd/handle_redirections.c:65)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
==42382==
==42382== Open file descriptor 7: /dev/pts/3
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9B9: handle_redirections (src/executing/simple_cmd/handle_redirections.c:64)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
==42382==
==42382== Open file descriptor 6: /dev/pts/3
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9CC: handle_redirections (src/executing/simple_cmd/handle_redirections.c:65)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
==42382==
==42382== Open file descriptor 5: /dev/pts/3
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9B9: handle_redirections (src/executing/simple_cmd/handle_redirections.c:64)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
==42382==
==42382== Open file descriptor 4: /dev/pts/3
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9A6: handle_redirections (src/executing/simple_cmd/handle_redirections.c:63)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
==42382==
==42382== Open file descriptor 3: /tmp/minishell_here_doc_78Ak8J9TeVu (deleted)
==42382==    at 0x49A8C1B: dup (in /nix/store/nqb2ns2d1lahnd5ncwmn6k84qfd7vx2k-glibc-2.40-36/lib/libc.so.6)
==42382==    by 0x10C9A6: handle_redirections (src/executing/simple_cmd/handle_redirections.c:63)
==42382==    by 0x10CBF6: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:91)
==42382==    by 0x10B10C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==42382==    by 0x10A4DD: execute_command (src/minishell.c:37)
==42382==    by 0x10A3A2: main (src/minishell.c:89)
 2025-04-24 13:47:54 +02:00
Khaïs COLIN
9db47dc96d feat(redirection): print path of redirection target on redirection error 2025-04-24 13:42:31 +02:00
Khaïs COLIN
ac198727e9 feat(postprocess): show error when post-processing failure occurs 2025-04-24 12:45:00 +02:00
Khaïs COLIN
2180909285 fix(expansion/wildcard): do not remove quotes twice on non-pattern strings 
There is still an issue with removing too many quotes when expanding variables
(see #138). This will be tackled in a later PR.
 2025-04-24 12:45:00 +02:00
Khaïs COLIN
2dd20b21bc feat(redir): fieldsplit redir target, and handle ambiguous redirects 2025-04-24 12:44:33 +02:00
Khaïs COLIN
2ae001e00b fix(exec/redirections): did not correctly restore fds when executing builtins 
This caused redirections to keep stdout redirected to the outfile, which caused
problems with displaying the prmpt.

The shell hangs, but exits with C-d

Builtins affected:
echo hi > outfile
pwd > outfile
env > outfile
 2025-04-18 14:14:43 +02:00
Khaïs COLIN
c5e15903e0 fix(builtin/export): show error on invalid identifiers such as % and $ 2025-04-18 10:17:21 +02:00
Khaïs COLIN
efaf4708f9 fix(builtin/export): empty arguments were not identified as invalid identifiers 2025-04-18 10:03:09 +02:00
Khaïs COLIN
d44691a5b0 fix(exec): running a command with an absolute path which does not exist now gives correct error 
Before, it gave "Is a directory" error, but now it correctly gives "No such file
or directory".
 2025-04-18 09:25:11 +02:00
Khaïs COLIN
655ff36351 fix(susbt/variable): empty variables on their own are removed 2025-04-18 09:22:18 +02:00
Khaïs COLIN
f1a0af09f8 feat(here_doc): handle signals (^C, ^\) correctly 
This is a bit of a big commit, because I had to move some stuff to other files,
sorry about that. I can split it up if it's too big to review.
 2025-04-17 12:06:48 +02:00
Khaïs COLIN
5e6d7b3b4e fix(parsing/here_doc): segfault & invalid fd & premature exit 2025-04-17 11:25:59 +02:00
Khaïs COLIN
733ae1093a fix(exec): correctly exit subprocesses, do not keep multiple shells in parallel 2025-04-16 17:30:25 +02:00
Khaïs COLIN
2ea4afda4a clean: move around some imports 2025-04-16 16:41:54 +02:00
Khaïs COLIN
18225f3356 fix(executing): return code on unknown cmd was unchanged, is now set to 127 2025-04-16 15:00:20 +02:00
Khaïs COLIN
81ba53237c parsing: do not reset last_return_value at start of parsing 
we need to preserve it, to be able to show the return value from the last command
 2025-04-15 15:45:29 +02:00
Khaïs COLIN
0579d1f2fc
env: correctly handle write errors such as /dev/full 
The exit status of 125 for env in case of failure is documented in env(1).
 2025-04-15 15:19:27 +02:00
Khaïs COLIN
ffaf2582a3
pwd: correctly handle write errors 2025-04-15 15:19:27 +02:00
Khaïs COLIN
cfc95994de
echo: correctly handle write errors such as /dev/full 2025-04-15 15:19:27 +02:00
Khaïs COLIN
871180f6d8
connec_pipe_cmd_execute: setup pipes between commands 2025-04-15 15:19:27 +02:00
Khaïs COLIN
81febcfcdd
debug: show command about to be executed in debug mode 2025-04-15 15:19:27 +02:00
Khaïs COLIN
204ed35ff4
fix(connec_cmd_execute): do not execute more than one command per process 2025-04-15 15:17:52 +02:00
Khaïs COLIN
596b21fc2f
debug, destroy all new types (also some code for testing it) 2025-04-15 15:17:51 +02:00
Khaïs COLIN
18014cda98
token_type: add field with no logic for populating it 2025-04-15 15:15:30 +02:00
Khaïs COLIN
ba9751e089
do postprocessing for each simple_cmd before execution 2025-04-15 15:13:17 +02:00
Khaïs COLIN
386d2bcb3a
exec: correct error and return value when cmd is a directory 
minishell: /: Is a directory
$? = 126
 2025-04-15 15:11:50 +02:00
Khaïs COLIN
bb1390aac5
simple_cmd_execute: handle redirections 
I am very uncertain on if this is actually correct, but I am unable to test it
very much atm
 2025-04-15 15:11:50 +02:00
Khaïs COLIN
6f75f2d181
connec_cmd_execute: naive recursive pipe implementation (does not handle redirection) 2025-04-15 15:11:26 +02:00
Khaïs COLIN
df73b3d0c7
connec_cmd_execute: handle && and || 2025-04-15 15:11:26 +02:00
Khaïs COLIN
8feacccb15
group_cmd_execute: fork and passthrough to cmd_execute 2025-04-15 15:11:26 +02:00
Khaïs COLIN
425722801b
refactor(do_waitpid): put into own file for easier acces from other modules 2025-04-15 15:11:26 +02:00
Khaïs COLIN
f9f8a804a3
cmd_execute: execute simple commands 2025-04-15 15:11:11 +02:00
Khaïs COLIN
7af032539a
cmd_execute: initial scafholding 2025-04-15 15:11:11 +02:00
Khaïs COLIN
881c7f264c
signal: if a command is terminated by SIGQUIT, display that it core dumped 2025-04-15 15:11:11 +02:00
Khaïs COLIN
0cfa2677c5
fix(echo): echo - was treated as echo -n 
Small logic error on my part
 2025-04-15 15:03:13 +02:00
Khaïs COLIN
d40560bb37
unset: implement unset 2025-04-15 15:03:13 +02:00
Khaïs COLIN
1ef8b7a0ae
env: implement builtin env 2025-04-15 15:03:13 +02:00
Khaïs COLIN
0de583cf45
echo: implement builtin echo 2025-04-15 15:03:13 +02:00
Khaïs COLIN
715c2aced8
exit: handle invalid and large arguments 2025-04-15 15:03:13 +02:00
Khaïs COLIN
f1c132337b
exit: work for simple arguments 
This does not address non-integer arguments, or extremly high/low arguments.
 2025-04-15 15:03:13 +02:00
Khaïs COLIN
24ba87abba
exec: retain exit status of commands, including if they were signaled 2025-04-15 15:01:19 +02:00
Khaïs COLIN
5b7367925f
simple_cmd refactor: put subprocess functions in own file 
This clears some space for new functions later
 2025-04-15 14:41:44 +02:00
Khaïs COLIN
cea8043ec9
simple_cmd executing: show error in case execve fails 
We don't have to check the return status, since execve only returns on failure.

Fixes #52
 2025-04-15 14:41:43 +02:00
Jérôme Guélen
10a3c9c411
parse-cmd: Various fixes and a rotation of the parsing tree 2025-04-08 12:14:38 +02:00
Khaïs COLIN
0a80b9fbe3
simple_cmd executing refactor: put builtin related utilities into own file 2025-04-01 16:38:41 +02:00
Khaïs COLIN
ba4192bf8d
export: set correct exit status 2025-04-01 15:58:56 +02:00