minishell/Makefile
Khaïs COLIN 9d37d07589 fix(get_command_path): leak when path unset and calling file present in current dir
$ touch cat
$ unset PATH
$ cat
m==75845== Memcheck, a memory error detector
==75845== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==75845== Using Valgrind-3.23.0 and LibVEX; rerun with -h for copyright info
==75845== Command: ./minishell
==75845==
==75846== Memcheck, a memory error detector
==75846== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==75846== Using Valgrind-3.23.0 and LibVEX; rerun with -h for copyright info
==75846== Command: /nix/store/6wgd8c9vq93mqxzc7jhkl86mv6qbc360-coreutils-9.5/bin/touch cat
==75846==
==75846==
==75846== FILE DESCRIPTORS: 0 open (0 std) at exit.
==75846==
==75846== HEAP SUMMARY:
==75846==     in use at exit: 0 bytes in 0 blocks
==75846==   total heap usage: 46 allocs, 46 frees, 8,126 bytes allocated
==75846==
==75846== All heap blocks were freed -- no leaks are possible
==75846==
==75846== For lists of detected and suppressed errors, rerun with: -s
==75846== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
minishell: cat: Permission denied
==75849==
==75849== FILE DESCRIPTORS: 3 open (3 std) at exit.
==75849==
==75849== HEAP SUMMARY:
==75849==     in use at exit: 4,181 bytes in 12 blocks
==75849==   total heap usage: 982 allocs, 970 frees, 122,299 bytes allocated
==75849==
==75849== 8 bytes in 1 blocks are definitely lost in loss record 1 of 9
==75849==    at 0x48467D9: malloc (in /nix/store/phbnjdfmy3v4ak9xf211y2336mv5kx9s-valgrind-3.23.0/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==75849==    by 0x113C22: ft_calloc (ft_calloc.c:28)
==75849==    by 0x112399: get_paths_array (src/subst/simple_filename_exp.c:37)
==75849==    by 0x1121EE: filepath_from_env (src/subst/simple_filename_exp.c:144)
==75849==    by 0x1121C0: get_cmdpath (src/subst/simple_filename_exp.c:184)
==75849==    by 0x10CD97: exec_external_cmd (src/executing/simple_cmd/simple_cmd_execute.c:67)
==75849==    by 0x10CC58: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:94)
==75849==    by 0x10B12C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==75849==    by 0x10A4FD: execute_command (src/minishell.c:37)
==75849==    by 0x10A3B2: main (src/minishell.c:90)
==75849==
==75849== 24 bytes in 1 blocks are still reachable in loss record 6 of 9
==75849==    at 0x48467D9: malloc (in /nix/store/phbnjdfmy3v4ak9xf211y2336mv5kx9s-valgrind-3.23.0/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==75849==    by 0x113C22: ft_calloc (ft_calloc.c:28)
==75849==    by 0x10D4A9: cmd_create (src/parser/cmd/cmd.c:20)
==75849==    by 0x10F6A1: simple_cmd_create (src/parser/simple_cmd/simple_cmd_parse.c:24)
==75849==    by 0x10F4E4: minishell_simple_cmd_parse (src/parser/simple_cmd/simple_cmd_parse.c:38)
==75849==    by 0x10E078: minishell_group_or_simple_parse (src/parser/group_cmd/group_cmd_parse.c:53)
==75849==    by 0x10E4AC: minishell_pipeline_parse (src/parser/pipeline/pipeline_parse.c:26)
==75849==    by 0x10D93C: minishell_cmds_parse (src/parser/cmd/cmds_parse.c:30)
==75849==    by 0x1139D5: minishell_parse (src/parser/cmd_parsing.c:67)
==75849==    by 0x10A38B: main (src/minishell.c:87)
==75849==
==75849== LEAK SUMMARY:
==75849==    definitely lost: 8 bytes in 1 blocks
==75849==    indirectly lost: 0 bytes in 0 blocks
==75849==      possibly lost: 0 bytes in 0 blocks
==75849==    still reachable: 24 bytes in 1 blocks
==75849==         suppressed: 4,149 bytes in 10 blocks
==75849==
==75849== For lists of detected and suppressed errors, rerun with: -s
==75849== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
126
==75845==
==75845== FILE DESCRIPTORS: 3 open (3 std) at exit.
==75845==
==75845== HEAP SUMMARY:
==75845==     in use at exit: 4,201 bytes in 14 blocks
==75845==   total heap usage: 844 allocs, 830 frees, 72,248 bytes allocated
==75845==
==75845== 8 bytes in 1 blocks are definitely lost in loss record 1 of 8
==75845==    at 0x48467D9: malloc (in /nix/store/phbnjdfmy3v4ak9xf211y2336mv5kx9s-valgrind-3.23.0/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==75845==    by 0x113C22: ft_calloc (ft_calloc.c:28)
==75845==    by 0x112399: get_paths_array (src/subst/simple_filename_exp.c:37)
==75845==    by 0x1121EE: filepath_from_env (src/subst/simple_filename_exp.c:144)
==75845==    by 0x1121C0: get_cmdpath (src/subst/simple_filename_exp.c:184)
==75845==    by 0x10CD97: exec_external_cmd (src/executing/simple_cmd/simple_cmd_execute.c:67)
==75845==    by 0x10CC58: simple_cmd_execute (src/executing/simple_cmd/simple_cmd_execute.c:94)
==75845==    by 0x10B12C: cmd_execute (src/executing/cmd/cmd_execute.c:23)
==75845==    by 0x10A4FD: execute_command (src/minishell.c:37)
==75845==    by 0x10A3B2: main (src/minishell.c:90)
==75845==
==75845== LEAK SUMMARY:
==75845==    definitely lost: 8 bytes in 1 blocks
==75845==    indirectly lost: 0 bytes in 0 blocks
==75845==      possibly lost: 0 bytes in 0 blocks
==75845==    still reachable: 0 bytes in 0 blocks
==75845==         suppressed: 4,193 bytes in 13 blocks
==75845==
==75845== For lists of detected and suppressed errors, rerun with: -s
==75845== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)inishell: cat: Permission denied
2025-04-24 18:03:25 +02:00

214 lines
5.7 KiB
Makefile

NAME = minishell
DEBUG = -g -O0
# -fno-omit-frame-pointer is to prevent malloc stacktraces from being truncated,
# see "My malloc stacktraces are too short" here:
# https://github.com/google/sanitizers/wiki/AddressSanitizer
ASAN = -fsanitize=address -fno-omit-frame-pointer
TSAN = -fsanitize=thread
UBSAN = -fsanitize=undefined
LDLIBS = \
-lreadline \
-lft
LIBFTDIR = ./libft/
LIBFT = $(LIBFTDIR)libft.a
IFLAGS = -I$(LIBFTDIR)
LINCLUDE = -L$(LIBFTDIR)
ifeq ($(CFLAGS),)
CFLAGS = -Wall -Wextra -Werror \
$(DEBUG) \
endif
export CFLAGS
srcs = \
src/buffer/buffer.c \
src/buffer/buffer_charptr.c \
src/env/env.c \
src/env/env_convert.c \
src/env/env_manip.c \
src/env/envp.c \
src/executing/cmd/cmd_execute.c \
src/executing/common/do_waitpid.c \
src/executing/connec_cmd/connec_cmd_execute.c \
src/executing/connec_cmd/connec_pipe_cmd_execute.c \
src/executing/group_cmd/group_cmd_execute.c \
src/executing/here_doc/here_doc.c \
src/executing/here_doc/here_doc_errors.c \
src/executing/here_doc/here_doc_expand_line.c \
src/executing/here_doc/here_doc_utils.c \
src/executing/here_doc/random_filename.c \
src/executing/here_doc/strip_newline.c \
src/executing/simple_cmd/builtin_cd.c \
src/executing/simple_cmd/builtin_echo.c \
src/executing/simple_cmd/builtin_env.c \
src/executing/simple_cmd/builtin_exit.c \
src/executing/simple_cmd/builtin_export.c \
src/executing/simple_cmd/builtin_invalid.c \
src/executing/simple_cmd/builtin_pwd.c \
src/executing/simple_cmd/builtin_unset.c \
src/executing/simple_cmd/builtins.c \
src/executing/simple_cmd/handle_redirections.c \
src/executing/simple_cmd/simple_cmd_execute.c \
src/executing/simple_cmd/simple_cmd_execute_debug.c \
src/executing/simple_cmd/subprocess.c \
src/ft_errno.c \
src/get_command.c \
src/parser/cmd/cmd.c \
src/parser/cmd/cmd_debug.c \
src/parser/cmd/cmd_destroy.c \
src/parser/cmd/cmds_parse.c \
src/parser/cmd/opt_cmds_parse.c \
src/parser/connec_cmd/connec_cmd_debug.c \
src/parser/connec_cmd/connec_reorient_subtree.c \
src/parser/group_cmd/group_cmd_debug.c \
src/parser/group_cmd/group_cmd_parse.c \
src/parser/matchers/blank.c \
src/parser/matchers/identifier.c \
src/parser/matchers/metacharacter.c \
src/parser/matchers/operator_combo.c \
src/parser/matchers/operator_start.c \
src/parser/matchers/pipe.c \
src/parser/matchers/quote.c \
src/parser/pipeline/optional_pipeline_parse.c \
src/parser/pipeline/pipeline_parse.c \
src/parser/redirect/redirect.c \
src/parser/redirect/redirect_debug.c \
src/parser/redirect/redirect_from_words.c \
src/parser/redirect/redirect_parse.c \
src/parser/remove_quotes/cmdgroup_remove_quotes.c \
src/parser/remove_quotes/remove_quotes.c \
src/parser/simple_cmd/simple_cmd.c \
src/parser/simple_cmd/simple_cmd_parse.c \
src/parser/worddesc/worddesc.c \
src/parser/worddesc/worddesc_debug.c \
src/parser/wordlist/wordlist.c \
src/parser/wordlist/wordlist_copy.c \
src/parser/wordlist/wordlist_debug.c \
src/parser/wordlist/wordlist_idx.c \
src/parser/wordlist/wordlist_quicksort.c \
src/parser/wordlist/wordlist_utils.c \
src/parser/wordsplit/get_token_type.c \
src/parser/wordsplit/rule_utils.c \
src/parser/wordsplit/tokenizing_1_5.c \
src/parser/wordsplit/tokenizing_6_10.c \
src/parser/wordsplit/wordsplit.c \
src/parser/wordsplit/wordsplit_utils.c \
src/postprocess/ambiguous_redirect.c \
src/postprocess/expansion/expand_vars.c \
src/postprocess/expansion/expand_wildcard.c \
src/postprocess/fieldsplit/fieldsplit.c \
src/postprocess/fieldsplit/redirect_fieldsplit.c \
src/sig/sig.c \
src/sig/sig_handlers.c \
src/subst/path_split.c \
src/subst/replace_substr.c \
src/subst/simple_filename_exp.c \
src/subst/simple_filename_exp_utils.c \
src/subst/simple_filename_exp_utils_utils.c \
src/subst/variable_subst.c \
src/subst/variable_subst_utils.c \
src/subst/wildcard_exp.c \
src/subst/wildcard_exp_utils.c \
src/subst/wildcard_exp_utils2.c \
src/treedrawing.c \
src/parser/cmd_parsing.c
objs = $(srcs:.c=.o)
export objs
minishell_objs = $(addsuffix .o,src/$(NAME)) $(objs)
all_objs = $(minishell_objs)
deps = $(all_objs:.o=.d)
.PHONY: all clean fclean re norm tests ctests ctestsa ctestsub ctestst alla \
allub allt testsa testsub testst inttests inttestsa inttestsub inttestst
all: $(NAME)
-include $(deps)
$(NAME): $(minishell_objs) $(LIBFT)
$(CC) $(CFLAGS) -o $@ $(minishell_objs) $(LINCLUDE) $(LDLIBS)
$(LIBFT): CFLAGS+=-DBUFFER_SIZE=1
$(LIBFT):
+$(MAKE) -C $(LIBFTDIR)
%.o: %.c
$(CC) -c $(CFLAGS) $(IFLAGS) -o $*.o $*.c
$(CC) -MM $(CFLAGS) $(IFLAGS) -MT $*.o $*.c > $*.d
clean:
+$(MAKE) -C $(LIBFTDIR) clean
find . -name '*.o' -print -delete
find . -name '*.d' -print -delete
fclean: clean
$(MAKE) -C $(LIBFTDIR) fclean
rm -f $(NAME)
+make -C tests fclean
re:
+make fclean
+make all
norm:
norminette src libft | grep -v OK || true
tests:
+make fclean
+make testsa
+make fclean
+make testsub
+make fclean
+make testst
@echo "All tests passed!"
testsa: CFLAGS += $(ASAN)
testsa:
@echo "Running tests with AddressSanitizer..."
+make inttests
+make ctests
testsub: CFLAGS += $(UBSAN)
testsub: all
@echo "Running tests with UndefinedBehaviourSanitizer..."
+make inttests
+make ctests
testst: CFLAGS += $(TSAN)
testst: all
@echo "Running tests with ThreadSanitizer..."
+make inttests
+make ctests
inttests: all
./test.sh
inttestsa: CFLAGS += $(ASAN)
inttestsa: all
./test.sh
inttestsub: CFLAGS += $(UBSAN)
inttestsub: all
./test.sh
inttestst: CFLAGS += $(TSAN)
inttestst: all
./test.sh
ctests: $(LIBFT) all
ctestsa: CFLAGS += $(ASAN)
ctestsa: ctests
ctestsub: CFLAGS += $(UBSAN)
ctestsub: ctests
ctestst: CFLAGS += $(TSAN)
ctestst: ctests
alla: CFLAGS += $(ASAN)
alla: all
allub: CFLAGS += $(UBSAN)
allub: all
allt: CFLAGS += $(TSAN)
allt: all