logistic-bot/nix-doom-emacs-unstraightened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always fetch allRefs

Browse source 
Having CI confirm allRefs false is still safe would require a network
hit for each repo, which is already problematic. But
https://github.com/NixOS/nix/issues/7120 means we'd need to drop CI's
cached content, not just its cached refs: given how much we're fetching
that seems too much.

Fetch all refs unconditionally, assuming we're typically re-fetching the
same fixed rev repeatedly, which should be cached.
This commit is contained in:
Marien Zwart 2024-05-25 12:46:43 +10:00
parent 363cb033fb
commit 6401eecb57
No known key found for this signature in database
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
default.nix
View file

@ -52,7 +52,7 @@
}: }:
let let
inherit (lib) optionalAttrs optionalString; inherit (lib) optionalAttrs optionalString;
inherit (import ./fetch-overrides.nix) extraPins extraUrls allRefsRepos; inherit (import ./fetch-overrides.nix) extraPins extraUrls;
# Step 1: determine which Emacs packages to pull in. # Step 1: determine which Emacs packages to pull in.
# #
@ -239,7 +239,7 @@ let
{ {
inherit url; inherit url;
rev = pin; rev = pin;
allRefs = allRefsRepos.${url} or false; allRefs = true;
submodules = !(p.recipe.nonrecursive or false); submodules = !(p.recipe.nonrecursive or false);
# TODO: pull ref from derivation.src when not pulling it from p.recipe? # TODO: pull ref from derivation.src when not pulling it from p.recipe?
# Note Doom does have packages with pin + branch (or nonrecursive) set, # Note Doom does have packages with pin + branch (or nonrecursive) set,

6
fetch-overrides.nix
View file

@ -39,10 +39,4 @@
# In emacsattic, so shouldn't change underneath us. # In emacsattic, so shouldn't change underneath us.
ammonite-term-repl = "b552fe21977e005c1c460bf6607557e67241a6b6"; ammonite-term-repl = "b552fe21977e005c1c460bf6607557e67241a6b6";
}; };
# TODO figure out whether we're better off always setting allRefs.
allRefsRepos = {
"https://git.savannah.gnu.org/git/emms.git" = true;
"https://git.notmuchmail.org/git/notmuch" = true;
};
} }