osdb/notes.org
Khaïs COLIN 55b4779964 refactor(CommandParseError): remove the display implementation
we want to be able to give additional arguments to the display function later,
so this is needed
2025-05-04 13:45:09 +02:00

4.1 KiB
Raw Blame History

Notes

DONE show errors with ariadne

[X] errors should have a generic show() function

CLOCK: [2025-05-03 sam. 18:40][2025-05-03 sam. 18:46] => 0:06

DONE OSDBError::display() should take a filename and display it alongside the error

CLOCK: [2025-05-03 sam. 21:24][2025-05-03 sam. 21:28] => 0:04

DONE OSDBError::display() should take an input string, to be able to resolve spans inside the error

CLOCK: [2025-05-03 sam. 21:28][2025-05-03 sam. 21:30] => 0:02

DONE OSDBError::display() should generate ariadne errors and return those

CLOCK: [2025-05-03 sam. 21:30][2025-05-03 sam. 21:50] => 0:20

DONE error display should include a span to show where the error occured

CLOCK: [2025-05-03 sam. 21:51][2025-05-03 sam. 21:54] => 0:03

DONE deduplicate error display code

CLOCK: [2025-05-03 sam. 21:55][2025-05-03 sam. 22:01] => 0:06

DONE snapshot testing

DONE Find the snapshot testing library

CLOCK: [2025-05-03 sam. 18:48][2025-05-03 sam. 18:49] => 0:01

DONE document myself on insta, the snapshot testing library

CLOCK: [2025-05-03 sam. 18:49][2025-05-03 sam. 18:57] => 0:08

DONE insta test startup message

CLOCK: [2025-05-03 sam. 19:00][2025-05-03 sam. 19:05] => 0:05

DONE insta test insert

CLOCK: [2025-05-03 sam. 21:10][2025-05-03 sam. 21:14] => 0:04 CLOCK: [2025-05-03 sam. 19:08][2025-05-03 sam. 19:21] => 0:13

DONE all display of command results must be made via a display method on CommandExecutionResult

CLOCK: [2025-05-03 sam. 21:02][2025-05-03 sam. 21:09] => 0:07

DONE insta test select

CLOCK: [2025-05-03 sam. 21:15][2025-05-03 sam. 21:16] => 0:01

DONE insta test .exit

CLOCK: [2025-05-03 sam. 21:16][2025-05-03 sam. 21:18] => 0:02

DONE insta test wrong statement

CLOCK: [2025-05-03 sam. 21:18][2025-05-03 sam. 21:21] => 0:03

DONE insta test wrong meta-command

CLOCK: [2025-05-03 sam. 21:21][2025-05-03 sam. 21:22] => 0:01

DONE exit message is not displayed when pressing C-d   bug

CLOCK: [2025-05-03 sam. 19:06][2025-05-03 sam. 19:07] => 0:01

TODO switch statement parsing to more extensible token-based algorithm

CLOCK: [2025-05-04 dim. 12:07][2025-05-04 dim. 12:10] => 0:03

TODO use tokens to parse meta-commands

CLOCK: [2025-05-04 dim. 12:10][2025-05-04 dim. 12:22] => 0:12

DONE recognize meta-commands as tokens

CLOCK: [2025-05-04 dim. 13:32][2025-05-04 dim. 13:35] => 0:03 CLOCK: [2025-05-04 dim. 13:27][2025-05-04 dim. 13:32] => 0:05

DONE CommandParseError must have a ScanError variant with an Into impl

CLOCK: [2025-05-04 dim. 13:35][2025-05-04 dim. 13:38] => 0:03

TODO ScanErrors must be convertible to ariadne reports

DONE Remove the CommandParseError Display implementation

CLOCK: [2025-05-04 dim. 13:38][2025-05-04 dim. 13:44] => 0:06

TODO implement OSDBError for ScanError

TODO remove token types which are not recognized at all

TODO parse tokens into meta-commands

TODO use tokens to parse statements